fix: image must be url in create ads

internal/api/http/ads/create.go

@@ -1,106 +1,68 @@
 package adshttp
 
 import (
-	"fmt"
 	authmiddleware "legalgo-BE-go/internal/api/http/middleware/auth"
 	adsdomain "legalgo-BE-go/internal/domain/ads"
-	"legalgo-BE-go/internal/domain/oss"
 	adssvc "legalgo-BE-go/internal/services/ads"
 	"legalgo-BE-go/internal/utilities/response"
+	"legalgo-BE-go/internal/utilities/utils"
 	"net/http"
 
 	"github.com/go-chi/chi/v5"
+	"github.com/go-playground/validator/v10"
 )
 
-const _oneMB = 1 << 20
-const _maxUploadSize = 2 * _oneMB
-const _folderName = "/file"
-
 func Create(
 	router chi.Router,
 	adsSvc adssvc.Ads,
+	validate *validator.Validate,
 ) {
-	router.With(authmiddleware.Authorize()).Post("/ads/create", func(w http.ResponseWriter, r *http.Request) {
+	router.
-		ctx := r.Context()
+		With(authmiddleware.Authorize()).
+		Post("/ads/create", func(w http.ResponseWriter, r *http.Request) {
+			ctx := r.Context()
+			var spec adsdomain.AdsReq
 
-		err := r.ParseMultipartForm(10 << 20) // 10 MB
+			if err := utils.UnmarshalBody(r, &spec); err != nil {
-		if err != nil {
+				response.RespondJsonErrorWithCode(
-			response.RespondJsonErrorWithCode(
+					ctx,
-				ctx,
+					w,
-				w,
+					err,
-				err,
+					response.ErrBadRequest.Code,
-				response.ErrBadRequest.Code,
+					response.ErrBadRequest.HttpCode,
-				response.ErrBadRequest.HttpCode,
+					"failed to unmarshal body",
-				"unable to parse form",
+				)
-			)
+				return
-			return
+			}
-		}
 
-		url := r.FormValue("url")
+			if err := validate.Struct(spec); err != nil {
-		if url == "" {
+				response.ResponseWithErrorCode(
-			response.RespondJsonErrorWithCode(
+					ctx,
-				ctx,
+					w,
-				w,
+					err,
-				err,
+					response.ErrBadRequest.Code,
-				response.ErrBadRequest.Code,
+					response.ErrBadRequest.HttpCode,
-				response.ErrBadRequest.HttpCode,
+					err.(validator.ValidationErrors).Error(),
-				"URL is missing",
+				)
-			)
+				return
-			return
+			}
-		}
 
-		file, header, err := r.FormFile("image")
+			if err := adsSvc.Create(spec); err != nil {
-		if err != nil {
+				response.RespondJsonErrorWithCode(
-			response.RespondJsonErrorWithCode(
+					ctx,
-				ctx,
+					w,
-				w,
+					err,
-				err,
+					response.ErrBadRequest.Code,
-				response.ErrBadRequest.Code,
+					response.ErrBadRequest.HttpCode,
-				response.ErrBadRequest.HttpCode,
+					err.Error(),
-				"unable to retrieve image",
+				)
-			)
+				return
-			return
+			}
-		}
-		defer file.Close()
 
-		if header.Size > int64(_maxUploadSize) {
+			response.RespondJsonSuccess(ctx, w, struct {
-			response.ResponseWithErrorCode(
+				Message string
-				ctx,
+			}{
-				w,
+				Message: "ads created successfully",
-				fmt.Errorf("file too big"),
+			})
-				response.ErrBadRequest.Code,
-				response.ErrBadRequest.HttpCode,
-				fmt.Sprintf("The file is too big. The maximum size is %d MB", _maxUploadSize/_oneMB),
-			)
-			return
-		}
-
-		imageRequest := &oss.UploadFileRequest{
-			FileHeader: header,
-			FolderName: _folderName,
-		}
-
-		adsReq := adsdomain.AdsReq{
-			Image: imageRequest,
-			Url:   url,
-		}
-
-		if err := adsSvc.Create(ctx, adsReq); err != nil {
-			response.RespondJsonErrorWithCode(
-				ctx,
-				w,
-				err,
-				response.ErrBadRequest.Code,
-				response.ErrBadRequest.HttpCode,
-				err.Error(),
-			)
-			return
-		}
-
-		response.RespondJsonSuccess(ctx, w, struct {
-			Message string
-		}{
-			Message: "ads created successfully",
 		})
-	})
 }

internal/domain/ads/spec.go

@@ -1,7 +1,6 @@
 package adsdomain
 
 import (
-	"legalgo-BE-go/internal/domain/oss"
 	"time"
 )
 
@@ -14,6 +13,6 @@ type Ads struct {
 }
 
 type AdsReq struct {
-	Image *oss.UploadFileRequest `json:"image"`
+	Image string `json:"image" validate:"required"`
-	Url   string                 `json:"url"`
+	URL   string `json:"url" validate:"required"`
 }

internal/services/ads/create.go

@@ -1,56 +1,27 @@
 package adssvc
 
 import (
-	"context"
 	"fmt"
 	adsdomain "legalgo-BE-go/internal/domain/ads"
-	"path"
+	"strings"
 
 	"github.com/google/uuid"
 )
 
-func (i *impl) Create(ctx context.Context, spec adsdomain.AdsReq) error {
+func (i *impl) Create(spec adsdomain.AdsReq) error {
-	id := uuid.NewString()
+	if !(strings.HasPrefix(spec.Image, "http")) {
-
+		return fmt.Errorf("image url is not started with http")
-	file := spec.Image.FileHeader
-	spec.Image.FileSize = file.Size
-	spec.Image.Ext = path.Ext(file.Filename)
-
-	if err := i.validate.Struct(spec); err != nil {
-		return err
 	}
 
-	// Open the file and read its content
+	if !(strings.HasPrefix(spec.URL, "http")) {
-	srcFile, err := file.Open()
+		return fmt.Errorf("url is not started with http")
-	if err != nil {
-		return err
-	}
-	defer srcFile.Close()
-
-	fileContent := make([]byte, file.Size)
-	_, err = srcFile.Read(fileContent)
-	if err != nil {
-		return err
-	}
-
-	filePath := fmt.Sprintf("%v/%v%v", spec.Image.FolderName, id, spec.Image.Ext)
-	fileUrl, err := i.ossRepo.UploadFile(ctx, filePath, fileContent)
-	if err != nil {
-		return err
 	}
 
 	newSpec := adsdomain.Ads{
-		ID:       id,
+		ID:       uuid.NewString(),
-		ImageUrl: fileUrl,
+		ImageUrl: spec.Image,
-		Url:      spec.Url,
+		Url:      spec.URL,
 	}
 
-	if err := i.adsRepo.Create(newSpec); err != nil {
+	return i.adsRepo.Create(newSpec)
-		if err := i.ossRepo.DeleteObject(ctx, id); err != nil {
-			return err
-		}
-		return err
-	}
-
-	return nil
 }

internal/services/ads/impl.go

@@ -1,7 +1,6 @@
 package adssvc
 
 import (
-	"context"
 	adsrepository "legalgo-BE-go/internal/accessor/ads"
 	"legalgo-BE-go/internal/accessor/oss"
 	adsdomain "legalgo-BE-go/internal/domain/ads"
@@ -16,7 +15,7 @@ type impl struct {
 }
 
 type Ads interface {
-	Create(context.Context, adsdomain.AdsReq) error
+	Create(adsdomain.AdsReq) error
 	GetAll() ([]adsdomain.Ads, error)
 }