From 609866beefabb439df5cc94979a6c84a902b0f18 Mon Sep 17 00:00:00 2001 From: Ardeman Date: Sat, 8 Mar 2025 15:03:45 +0800 Subject: [PATCH] feat: update news detail loader to use route parameters and fix typo in TODO comment --- app/routes/_news.detail.$slug.tsx | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/app/routes/_news.detail.$slug.tsx b/app/routes/_news.detail.$slug.tsx index cad0d64..27c2d25 100644 --- a/app/routes/_news.detail.$slug.tsx +++ b/app/routes/_news.detail.$slug.tsx @@ -5,7 +5,7 @@ import { NewsDetailPage } from '~/pages/news-detail' import type { Route } from './+types/_news.detail.$slug' -export const loader = async ({ request }: Route.LoaderArgs) => { +export const loader = async ({ request, params }: Route.LoaderArgs) => { const { userToken } = await handleCookie(request) let userData if (userToken) { @@ -14,18 +14,15 @@ export const loader = async ({ request }: Route.LoaderArgs) => { }) userData = data } - // TODO need handel if user not accses non premium data + // TODO need handle if user not access non premium data const { data: newsDetailData } = await getNewsBySlug({ - slug: request.url.split('/').pop() ?? '', + slug: params.slug, accessToken: userToken, }) - // const { data: categoriesData } = await getCategories() - return { newsDetailData, userData, - // categoriesData, } }