legalgonews/legalgo-FE-reactrouter
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix: update effect dependencies to use fetcher.data for improved error handling in dialogs

Browse Source
This commit is contained in:
Ardeman 2025-03-15 17:27:49 +08:00
parent e7ef7177ca
commit 7b840ce5cd
5 changed files with 13 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
app/layouts/admin/dialog-upload.tsx
View File

@ -37,7 +37,7 @@ export const DialogUpload = () => {
setUploadedFile(fetcher.data.uploadData.data.file_url) setUploadedFile(fetcher.data.uploadData.data.file_url)
// eslint-disable-next-line react-hooks/exhaustive-deps // eslint-disable-next-line react-hooks/exhaustive-deps
}, [fetcher]) }, [fetcher.data])
const handleChange = async function (event: ChangeEvent<HTMLInputElement>) { const handleChange = async function (event: ChangeEvent<HTMLInputElement>) {
event.preventDefault() event.preventDefault()

6
app/layouts/news/dialog-login.tsx
View File

@ -36,8 +36,8 @@ export const DialogLogin = () => {
const { handleSubmit } = formMethods const { handleSubmit } = formMethods
useEffect(() => { useEffect(() => {
if (!fetcher.data?.success) { if (!fetcher.data?.success && fetcher.data?.message) {
toast.error(fetcher.data?.message) toast.error(fetcher.data.message)
return return
} }
@ -47,7 +47,7 @@ export const DialogLogin = () => {
setIsSubscribeOpen(true) setIsSubscribeOpen(true)
} }
// eslint-disable-next-line react-hooks/exhaustive-deps // eslint-disable-next-line react-hooks/exhaustive-deps
}, [fetcher]) }, [fetcher.data])
return ( return (
<DialogNews <DialogNews

6
app/layouts/news/dialog-register.tsx
View File

@ -58,15 +58,15 @@ export const DialogRegister = () => {
const { handleSubmit, control } = formMethods const { handleSubmit, control } = formMethods
useEffect(() => { useEffect(() => {
if (!fetcher.data?.success) { if (!fetcher.data?.success && fetcher.data?.message) {
toast.error(fetcher.data?.message) toast.error(fetcher.data.message)
return return
} }
setIsRegisterOpen(false) setIsRegisterOpen(false)
setIsSuccessOpen('register') setIsSuccessOpen('register')
// eslint-disable-next-line react-hooks/exhaustive-deps // eslint-disable-next-line react-hooks/exhaustive-deps
}, [fetcher]) }, [fetcher.data])
return ( return (
<DialogNews <DialogNews

6
app/layouts/news/dialog-subscribe-plan.tsx
View File

@ -43,15 +43,15 @@ export const DialogSubscribePlan = () => {
const { handleSubmit } = formMethods const { handleSubmit } = formMethods
useEffect(() => { useEffect(() => {
if (!fetcher.data?.success) { if (!fetcher.data?.success && fetcher.data?.message) {
toast.error(fetcher.data?.message) toast.error(fetcher.data.message)
return return
} }
setIsSubscribeOpen(false) setIsSubscribeOpen(false)
setIsSuccessOpen('payment') setIsSuccessOpen('payment')
// eslint-disable-next-line react-hooks/exhaustive-deps // eslint-disable-next-line react-hooks/exhaustive-deps
}, [fetcher]) }, [fetcher.data])
return ( return (
<DialogNews <DialogNews

6
app/pages/staff-login/index.tsx
View File

@ -27,12 +27,12 @@ export const AdminLoginPage = () => {
const { handleSubmit } = formMethods const { handleSubmit } = formMethods
useEffect(() => { useEffect(() => {
if (!fetcher.data?.success) { if (!fetcher.data?.success && fetcher.data?.message) {
toast.error(fetcher.data?.message) toast.error(fetcher.data.message)
return return
} }
// eslint-disable-next-line react-hooks/exhaustive-deps // eslint-disable-next-line react-hooks/exhaustive-deps
}, [fetcher]) }, [fetcher.data])
return ( return (
<div className="flex min-h-dvh min-w-dvw flex-col items-center justify-center space-y-8"> <div className="flex min-h-dvh min-w-dvw flex-col items-center justify-center space-y-8">