fix: streamline error handling in dialogs by removing unnecessary return statements

app/components/dialog/delete.tsx

@@ -25,13 +25,11 @@ export const DialogDelete = (properties: TProperties) => {
   useEffect(() => {
     if (!fetcher.data?.success && fetcher.data?.message) {
       toast.error(fetcher.data.message)
-      return
     }
 
     if (fetcher.data?.success) {
       close()
       toast.success(`${title} berhasil dihapus!`)
-      return
     }
     // eslint-disable-next-line react-hooks/exhaustive-deps
   }, [fetcher.data])

app/layouts/admin/dialog-profile.tsx

@@ -31,12 +31,10 @@ export const DialogProfile = () => {
   useEffect(() => {
     if (!fetcher.data?.success && fetcher.data?.message) {
       toast.error(fetcher.data.message)
-      return
     }
 
     if (fetcher.data?.success) {
       setEditProfile(false)
-      return
     }
     // eslint-disable-next-line react-hooks/exhaustive-deps
   }, [fetcher.data])

app/layouts/admin/dialog-upload.tsx

@@ -32,10 +32,11 @@ export const DialogUpload = () => {
   useEffect(() => {
     if (!fetcher.data?.success && fetcher.data?.message) {
       toast.error(fetcher.data.message)
-      return
     }
 
+    if (fetcher.data?.success) {
       setUploadedFile(fetcher.data.uploadData.data.file_url)
+    }
     // eslint-disable-next-line react-hooks/exhaustive-deps
   }, [fetcher.data])
 

app/layouts/news/dialog-login.tsx

@@ -41,7 +41,9 @@ export const DialogLogin = () => {
       return
     }
 
+    if (fetcher.data?.success) {
       setIsLoginOpen(false)
+    }
 
     if (fetcher.data?.user.subscribe?.subscribe_plan?.code === 'basic') {
       setIsSubscribeOpen(true)

app/layouts/news/dialog-register.tsx

@@ -60,11 +60,12 @@ export const DialogRegister = () => {
   useEffect(() => {
     if (!fetcher.data?.success && fetcher.data?.message) {
       toast.error(fetcher.data.message)
-      return
     }
 
+    if (fetcher.data?.success) {
       setIsRegisterOpen(false)
       setIsSuccessOpen('register')
+    }
     // eslint-disable-next-line react-hooks/exhaustive-deps
   }, [fetcher.data])
 

app/layouts/news/dialog-subscribe-plan.tsx

@@ -45,11 +45,12 @@ export const DialogSubscribePlan = () => {
   useEffect(() => {
     if (!fetcher.data?.success && fetcher.data?.message) {
       toast.error(fetcher.data.message)
-      return
     }
 
+    if (fetcher.data?.success) {
       setIsSubscribeOpen(false)
       setIsSuccessOpen('payment')
+    }
     // eslint-disable-next-line react-hooks/exhaustive-deps
   }, [fetcher.data])
 

app/pages/form-advertisements/index.tsx

@@ -54,13 +54,11 @@ export const FormAdvertisementsPage = (properties: TProperties) => {
   useEffect(() => {
     if (!fetcher.data?.success && fetcher.data?.message) {
       toast.error(fetcher.data.message)
-      return
     }
 
     if (fetcher.data?.success) {
       toast.success(`Banner iklan berhasil ${adData ? 'diupdate' : 'dibuat'}!`)
       navigate('/lg-admin/advertisements')
-      return
     }
     // eslint-disable-next-line react-hooks/exhaustive-deps
   }, [fetcher.data])

app/pages/form-category/index.tsx

@@ -46,7 +46,6 @@ export const FormCategoryPage = (properties: TProperties) => {
   useEffect(() => {
     if (!fetcher.data?.success && fetcher.data?.message) {
       toast.error(fetcher.data.message)
-      return
     }
 
     if (fetcher.data?.success) {
@@ -54,7 +53,6 @@ export const FormCategoryPage = (properties: TProperties) => {
         `Kategori berhasil ${categoryData ? 'diupdate' : 'dibuat'}!`,
       )
       navigate('/lg-admin/categories')
-      return
     }
     // eslint-disable-next-line react-hooks/exhaustive-deps
   }, [fetcher.data])

app/pages/form-contents/index.tsx

@@ -98,13 +98,11 @@ export const FormContentsPage = (properties: TProperties) => {
   useEffect(() => {
     if (!fetcher.data?.success && fetcher.data?.message) {
       toast.error(fetcher.data.message)
-      return
     }
 
     if (fetcher.data?.success) {
       toast.success(`Artikel berhasil ${newsData ? 'diupdate' : 'dibuat'}!`)
       navigate('/lg-admin/contents')
-      return
     }
     // eslint-disable-next-line react-hooks/exhaustive-deps
   }, [fetcher.data])

app/pages/form-subscribe-plan/index.tsx

@@ -50,7 +50,6 @@ export const FormSubscribePlanPage = (properties: TProperties) => {
   useEffect(() => {
     if (!fetcher.data?.success && fetcher.data?.message) {
       toast.error(fetcher.data.message)
-      return
     }
 
     if (fetcher.data?.success) {
@@ -58,7 +57,6 @@ export const FormSubscribePlanPage = (properties: TProperties) => {
         `Subscribe Plan berhasil ${subscribePlanData ? 'diupdate' : 'dibuat'}!`,
       )
       navigate('/lg-admin/subscribe-plan')
-      return
     }
     // eslint-disable-next-line react-hooks/exhaustive-deps
   }, [fetcher.data])

app/pages/form-tag/index.tsx

@@ -42,13 +42,11 @@ export const FormTagPage = (properties: TProperties) => {
   useEffect(() => {
     if (!fetcher.data?.success && fetcher.data?.message) {
       toast.error(fetcher.data.message)
-      return
     }
 
     if (fetcher.data?.success) {
       toast.success(`Tag berhasil ${tagData ? 'diupdate' : 'dibuat'}!`)
       navigate('/lg-admin/tags')
-      return
     }
     // eslint-disable-next-line react-hooks/exhaustive-deps
   }, [fetcher.data])

app/pages/staff-login/index.tsx

@@ -29,7 +29,6 @@ export const AdminLoginPage = () => {
   useEffect(() => {
     if (!fetcher.data?.success && fetcher.data?.message) {
       toast.error(fetcher.data.message)
-      return
     }
     // eslint-disable-next-line react-hooks/exhaustive-deps
   }, [fetcher.data])