From eedb1558802c9b87c9f9b9b20143abb59a7c83b1 Mon Sep 17 00:00:00 2001
From: Ardeman <are.theman@gmail.com>
Date: Tue, 25 Mar 2025 19:25:49 +0800
Subject: [PATCH] refactor: remove ProfileIcon component and update image
 handling for author profiles

---
 app/components/icons/profile.tsx       | 23 -----------------------
 app/components/ui/news-author.tsx      | 18 ++++++++----------
 app/layouts/admin/navbar.tsx           | 21 +++++++++++----------
 app/pages/dashboard-contents/index.tsx |  2 +-
 app/pages/dashboard-staffs/index.tsx   | 18 +++++++++++++++---
 app/pages/dashboard-users/index.tsx    |  2 +-
 public/images/profile-placeholder.svg  |  6 ++++++
 7 files changed, 42 insertions(+), 48 deletions(-)
 delete mode 100644 app/components/icons/profile.tsx
 create mode 100644 public/images/profile-placeholder.svg

diff --git a/app/components/icons/profile.tsx b/app/components/icons/profile.tsx
deleted file mode 100644
index 240c438..0000000
--- a/app/components/icons/profile.tsx
+++ /dev/null
@@ -1,23 +0,0 @@
-import type { JSX, SVGProps } from 'react'
-
-export const ProfileIcon = (
-  properties: JSX.IntrinsicAttributes & SVGProps<SVGSVGElement>,
-) => {
-  return (
-    <svg
-      width={18}
-      height={19}
-      viewBox="0 0 18 19"
-      fill="none"
-      xmlns="http://www.w3.org/2000/svg"
-      {...properties}
-    >
-      <path
-        fillRule="evenodd"
-        clipRule="evenodd"
-        d="M12.97 5.82A3.956 3.956 0 019 9.789a3.956 3.956 0 01-3.97-3.97A3.955 3.955 0 019 1.853a3.955 3.955 0 013.97 3.968zM9 16.852c-3.253 0-6-.53-6-2.57s2.764-2.55 6-2.55c3.254 0 6 .529 6 2.569s-2.764 2.55-6 2.55z"
-        fill="currentColor"
-      />
-    </svg>
-  )
-}
diff --git a/app/components/ui/news-author.tsx b/app/components/ui/news-author.tsx
index 20537ae..3a3fa5f 100644
--- a/app/components/ui/news-author.tsx
+++ b/app/components/ui/news-author.tsx
@@ -1,5 +1,4 @@
 import type { TAuthorResponse } from '~/apis/common/get-news'
-import { ProfileIcon } from '~/components/icons/profile'
 import { formatDate } from '~/utils/formatter'
 
 type TDetailNewsAuthor = {
@@ -11,15 +10,14 @@ type TDetailNewsAuthor = {
 export const NewsAuthor = ({ author, live_at, text }: TDetailNewsAuthor) => {
   return (
     <div className="mb-2 flex items-center gap-2 align-middle">
-      {author?.profile_picture ? (
-        <img
-          src={author?.profile_picture}
-          alt={author?.name}
-          className="size-12 rounded-full bg-[#C4C4C4] object-cover"
-        />
-      ) : (
-        <ProfileIcon className="size-12 rounded-full bg-[#C4C4C4]" />
-      )}
+      <img
+        src={author?.profile_picture || '/images/profile-placeholder.svg'}
+        onError={(event) => {
+          event.currentTarget.src = '/images/profile-placeholder.svg'
+        }}
+        alt={author?.name}
+        className="size-12 rounded-full bg-[#C4C4C4] object-cover"
+      />
 
       <div>
         <h4 className="text-md">{author?.name}</h4>
diff --git a/app/layouts/admin/navbar.tsx b/app/layouts/admin/navbar.tsx
index 2e030a5..ceab65a 100644
--- a/app/layouts/admin/navbar.tsx
+++ b/app/layouts/admin/navbar.tsx
@@ -6,7 +6,6 @@ import {
 import { ChevronDownIcon } from '@heroicons/react/24/solid'
 import { Link, useFetcher, useRouteLoaderData } from 'react-router'
 
-import { ProfileIcon } from '~/components/icons/profile'
 import { Button } from '~/components/ui/button'
 import { APP } from '~/configs/meta'
 import { useAdminContext } from '~/contexts/admin'
@@ -34,15 +33,17 @@ export const Navbar = () => {
         <Popover className="relative">
           <PopoverButton className="flex w-3xs cursor-pointer items-center justify-between rounded-xl p-2 ring-1 ring-[#707FDD]/10 hover:shadow focus:outline-none">
             <div className="flex items-center space-x-3">
-              {staffData?.profile_picture ? (
-                <img
-                  src={staffData?.profile_picture}
-                  alt={staffData?.name}
-                  className="size-8 rounded-full bg-[#C4C4C4] object-cover"
-                />
-              ) : (
-                <ProfileIcon className="size-8 rounded-full bg-[#C4C4C4]" />
-              )}
+              <img
+                src={
+                  staffData?.profile_picture ||
+                  '/images/profile-placeholder.svg'
+                }
+                onError={(event) => {
+                  event.currentTarget.src = '/images/profile-placeholder.svg'
+                }}
+                alt={staffData?.name}
+                className="size-8 rounded-full bg-[#C4C4C4] object-cover"
+              />
 
               <span className="text-sm">{staffData?.name}</span>
             </div>
diff --git a/app/pages/dashboard-contents/index.tsx b/app/pages/dashboard-contents/index.tsx
index 656f164..4ab7b46 100644
--- a/app/pages/dashboard-contents/index.tsx
+++ b/app/pages/dashboard-contents/index.tsx
@@ -72,7 +72,7 @@ export const ContentsPage = () => {
     2: (value: TAuthorResponse) => (
       <>
         <div>{value.name}</div>
-        <div className="text-sm text-[#7C7C7C]">ID: {value.id.slice(0, 8)}</div>
+        <div className="text-xs text-[#7C7C7C]">ID: {value.id.slice(0, 8)}</div>
       </>
     ),
     3: (value: string) => <span className="text-sm">{value}</span>,
diff --git a/app/pages/dashboard-staffs/index.tsx b/app/pages/dashboard-staffs/index.tsx
index 98a7313..cd6b98c 100644
--- a/app/pages/dashboard-staffs/index.tsx
+++ b/app/pages/dashboard-staffs/index.tsx
@@ -39,9 +39,21 @@ export const StaffsPage = () => {
   ]
   const dataSlot: DataTableSlots = {
     1: (_value: unknown, _type: unknown, data: TStaffResponse) => (
-      <div>
-        <div>{data.name}</div>
-        <div className="text-sm text-[#7C7C7C]">ID: {data.id.slice(0, 8)}</div>
+      <div className="flex items-center gap-x-2">
+        <img
+          src={data?.profile_picture || '/images/profile-placeholder.svg'}
+          onError={(event) => {
+            event.currentTarget.src = '/images/profile-placeholder.svg'
+          }}
+          alt={data?.name}
+          className="size-8 rounded-full bg-[#C4C4C4] object-cover"
+        />
+        <div>
+          <div>{data.name}</div>
+          <div className="text-xs text-[#7C7C7C]">
+            ID: {data.id.slice(0, 8)}
+          </div>
+        </div>
       </div>
     ),
   }
diff --git a/app/pages/dashboard-users/index.tsx b/app/pages/dashboard-users/index.tsx
index 309a5bd..ebf30ac 100644
--- a/app/pages/dashboard-users/index.tsx
+++ b/app/pages/dashboard-users/index.tsx
@@ -55,7 +55,7 @@ export const UsersPage = () => {
     2: (_value: unknown, _type: unknown, data: TUserResponse) => (
       <div>
         <div>{data.email}</div>
-        <div className="text-sm text-[#7C7C7C]">ID: {data.id.slice(0, 8)}</div>
+        <div className="text-xs text-[#7C7C7C]">ID: {data.id.slice(0, 8)}</div>
       </div>
     ),
     3: (value: string) => <span>{value}</span>,
diff --git a/public/images/profile-placeholder.svg b/public/images/profile-placeholder.svg
new file mode 100644
index 0000000..76b9ccc
--- /dev/null
+++ b/public/images/profile-placeholder.svg
@@ -0,0 +1,6 @@
+<svg width="18" height="19" viewBox="0 0 18 19" fill="none" xmlns="http://www.w3.org/2000/svg"
+  class="size-8 rounded-full bg-[#C4C4C4]">
+  <path fill-rule="evenodd" clip-rule="evenodd"
+    d="M12.97 5.82A3.956 3.956 0 019 9.789a3.956 3.956 0 01-3.97-3.97A3.955 3.955 0 019 1.853a3.955 3.955 0 013.97 3.968zM9 16.852c-3.253 0-6-.53-6-2.57s2.764-2.55 6-2.55c3.254 0 6 .529 6 2.569s-2.764 2.55-6 2.55z"
+    fill="currentColor"></path>
+</svg>
\ No newline at end of file